Wait areBooleanEqual returns false when they are equal?
That’s not even the worst part. What the fuck does a function named Compare_anything do? Does it return anything? It sounds like nothing but a side effect.
The unnecessary and confusing functions are horrible, yes, but I’d still say that the fact that they’re wrong is the “worst” part.
Don’t forget the invocation
if (CompareBooleans(a, b) == true)
Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.
Programmers:
Add heavily verbose/redundant math equations that take up multiple lines with each operation saving to a new variable, then either decrease the number of variable declarations or condense/simplify the math occasionally. Repeat with each new function. Killing two metrics at once LOC and the removal of LOC for older functions. Guaranteed promotions. lol
There’s no way, that’s so insane it has layers.
This is code after working 16 hours
I’d give my right hand this is a code review problem. Someone extracted a method returning true false. Then an intern came along and was told to refactor. They saw a lot of comparisons and “extracted” them.
My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.