I don’t know bash scripting

if [ -d ~/.bashrc.d ]; then
	for rc in ~/.bashrc.d/*; do
		if [ -f "$rc" ]; then
			. "$rc"
		fi
	done

I asked chatgpt and it said this is non standard? There is no bashrc.d directory on my home folder, I have uncommented the lines for now but dont know if this is benign or malignant

35 points

It sources (includes) any file found in ~/.bashrc.d/ so check that directory.

permalink
report
reply
5 points

but there is no such directory

permalink
report
parent
reply
35 points

Then it does nothing.

permalink
report
parent
reply
11 points
*

Then it should have no effect.

This is just a nice way to define file-discrete .rc scripts. Like, maybe you have one for shell stuff, one for your custom collection of command aliases, one for initializing pyenv+pyenv-virtualenv, etc. That way, you have domain-constrained .rcs, and it’s easier to scan through things to see if something funny is going on / is broken or whatever.

permalink
report
parent
reply
6 points

It just checks to see if there is anything in a bash.d folder, if there isn’t it moves on. Just somebody being preemptively helpful to check for other locations

permalink
report
parent
reply
29 points

Check /etc/skel/.bashrc, if it’s in there as well, it was set up by your distro.

What it does is check for the existence of ~/.bashrc.d and, if it finds one, sources all the files inside it. This effectively means that you can create script files like ~/.bashrc.d/myfile.sh and they will have the same effect as if they had been put directly into .bashrc. Some people prefer having one file for each “bashrc thing” whilst some prefer just having one big file. Ultimately it’s personal preference.

permalink
report
reply
15 points

Ugh, I hate ChatGPT. If this is Bash (which it is, because it’s literally looking for files in a directory called ~/.bashrc.d), then it should god damned well be using syntax and language features that we’ve had for at least twenty fucking years. Specifically, if you’re writing for Bash (and not POSIX shell), you better be using [[ ]] rather than [ ]. This wiki is my holy book I use to keep the demons away when writing Bash, and it does a simply fantastic job of explaining why you should use God damned double square brackets.

ChatGPT writes shitty, horrible, buggy ass Bash. This is relatively decent for ChatGPT (it even makes sure the files are real files and not symlinks), but I’ve had to fix enough terrible fucking shitty AI Bash to have no tolerance for even the smallest misstep from it.

Sincerely, A senior developer who is known as the Bash wizard at work.

EDIT: Sorry, OP. ChatGPT did not, in fact, write this code, and I am going to leave my comment here as a testament to what a big smelly dick I was here.

permalink
report
reply
18 points

I think you misread both the question and how they used ChatGPT Mr Bash Wizard

permalink
report
parent
reply
21 points

oh fuck I did misread it. Man, now I sound like a big ol’ asshole. Sorry, OP :/ I had a bad week thanks to some ChatGPT code and just kinda jumped out when I saw the word “ChatGPT” next to Bash.

permalink
report
parent
reply
4 points

Hey man you’re human! Mistakes! Everyone makes them! At least you admit it, right :D

permalink
report
parent
reply
13 points

Looks like this is in the standard Fedora /etc/skel/.bashrc.

permalink
report
reply
10 points

It first checks if ~/.bashrc.d is an existing directory. If this it the case it then iterates over all entries in that directory. In this iteration it checks if the entry is a file and if this is the case it sources that file using the bash-internal shorthand . for source.

So it basically executes all scripts in ~/.bashrc.d. This makes it possible for you to split your bash configuration into multiple files. This quite common and a lot of programs already support it (100% depends on the program, though).

This is absolutely harmless as it is. But: if you or a program places anything in the directory ~/.bashrc.d it WILL be sourced everytime you start a bash.

A slightly better variant would be iterating over ~/.bashrc.d/*.sh instead of just ~/.bashrc.d/* to make sure to only grab files with the .sh suffix (even if suffixes are basically meaningless from a technical point of view) and also test for the file being executable (-x instead of -f).

This would make sure that only files that are ending with .sh and that are executable are sourced. The “attack vector”, if you want to call it like that, would then be a bit more narrow than just placing a file in a directory.

As for why it’s there: Did you ever touch your .bashrc? If not, maybe it is there since the beginning because it’s in the so-called skeleton (see /etc/skel/.bashrc) that was used to initialize certain files on user account creation.

permalink
report
reply

Linux

!linux@lemmy.ml

Create post

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word “Linux” in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

  • Posts must be relevant to operating systems running the Linux kernel. GNU/Linux or otherwise.
  • No misinformation
  • No NSFW content
  • No hate speech, bigotry, etc

Related Communities

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

Community stats

  • 8.2K

    Monthly active users

  • 3.7K

    Posts

  • 48K

    Comments