Which of these code styles do you find preferable?

First option using mut with constructor in the beginning:

  let mut post_form = PostInsertForm::new(
    data.name.trim().to_string(),
    local_user_view.person.id,
    data.community_id,
  );
  post_form.url = url.map(Into::into);
  post_form.body = body;
  post_form.alt_text = data.alt_text.clone();
  post_form.nsfw = data.nsfw;
  post_form.language_id = language_id;

Second option without mut and constructor at the end:

  let post_form = PostInsertForm {
    url: url.map(Into::into),
    body,
    alt_text: data.alt_text.clone(),
    nsfw: data.nsfw,
    language_id,
    ..PostInsertForm::new(
      data.name.trim().to_string(),
      local_user_view.person.id,
      data.community_id,
    )
  };

You can see the full PR here: https://github.com/LemmyNet/lemmy/pull/5037/files

You are viewing a single thread.
View all comments View context
1 point

Thats even more verbose so the second option is better.

permalink
report
parent
reply
6 points

Yeah if you have the second option, use it, but if the struct has private fields it won’t work.

permalink
report
parent
reply
2 points

The first one won’t work either for private fields.

permalink
report
parent
reply
2 points

You can have setters that set private fields, there are also sometimes structs with mixed private and public fields

permalink
report
parent
reply

Rust Programming

!rust@lemmy.ml

Create post

Community stats

  • 172

    Monthly active users

  • 93

    Posts

  • 161

    Comments

Community moderators